Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LD-204 Fix Image Overflow #827

Merged
merged 10 commits into from
Aug 20, 2024
Merged

LD-204 Fix Image Overflow #827

merged 10 commits into from
Aug 20, 2024

Conversation

DanDaManTran
Copy link
Contributor

@DanDaManTran DanDaManTran commented Jun 18, 2024

actual dimension or 100%width, moved width/height out of the style attributes and into the width/height attributes

…tributes and into the width/height attributes
@DanDaManTran DanDaManTran changed the title actual dimension or 100%width, moved width/height out of the style at… LD-204 Fix Image Overflow Jun 18, 2024
Copy link
Member

@chasenlehara chasenlehara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just made a couple comments that apply everywhere.

src/angular/15-directive/15-directive.md Outdated Show resolved Hide resolved
src/angular/4-adding-routing/adding-routing.md Outdated Show resolved Hide resolved
Copy link
Member

@chasenlehara chasenlehara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple little things to fix.

@chasenlehara chasenlehara merged commit cc10df3 into main Aug 20, 2024
1 check passed
@chasenlehara chasenlehara deleted the LD-204-FixImageOverflowNewReq branch August 20, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants